Dry up creating new AURP peers

main.go

@@ -65,13 +65,13 @@ const routingTableTemplate = `
 		<td>{{$route.LastSeenAgo}}</td>
 		<td>
 			{{- with $route.AURPPeer -}}
-				{{.RemoteAddr}}
+				[redacted]
 			{{- end -}}
 			{{- with $route.EtherTalkPeer -}}
 				{{.Port.Device}} {{.PeerAddr.Network}}.{{.PeerAddr.Node}}
 			{{- end -}}
 			{{- with $route.EtherTalkDirect -}}
-				{{.Device}} {{.NetStart}}-{{.NetEnd}}
+				{{.Device}}
 			{{- end -}}
 		</td>
 	</tr>
@@ -96,8 +96,8 @@ const peerTableTemplate = `
 	<tbody>
 {{range $peer := . }}
 	<tr>
-		<td>{{$peer.ConfiguredAddr}}</td>
-		<td>{{$peer.RemoteAddr}}</td>
+		<td>[redacted]</td>
+		<td>[redacted]</td>
 		<td>{{$peer.ReceiverState}}</td>
 		<td>{{$peer.SenderState}}</td>
 		<td>{{$peer.LastHeardFromAgo}}</td>
@@ -152,9 +152,9 @@ func main() {
 	}
 	localDI := aurp.IPDomainIdentifier(localIP)
 
-	log.Printf("Using %v as local domain identifier", localIP)
+	// log.Printf("Using %v as local domain identifier", localIP)
 
-	log.Printf("EtherTalk configuration: %+v", cfg.EtherTalk)
+	// log.Printf("EtherTalk configuration: %+v", cfg.EtherTalk)
 
 	ln, err := net.ListenUDP("udp4", &net.UDPAddr{Port: int(cfg.ListenPort)})
 	if err != nil {
@@ -256,12 +256,12 @@ func main() {
 
 	// ------------------------- Configured peer setup ------------------------
 	if cfg.PeerListURL != "" {
-		log.Printf("Fetching peer list from %s...", cfg.PeerListURL)
+		log.Print("Fetching peer list...")
 		existing := len(cfg.Peers)
 		func() {
 			resp, err := http.Get(cfg.PeerListURL)
 			if err != nil {
-				log.Fatalf("Couldn't fetch peer list: %v", err)
+				log.Fatalf("Couldn't fetch peer list!")
 			}
 			defer resp.Body.Close()
 
@@ -287,28 +287,17 @@ func main() {
 
 		raddr, err := net.ResolveUDPAddr("udp4", peerStr)
 		if err != nil {
-			log.Printf("couldn't resolve UDP address, skipping: %v", err)
+			log.Print("couldn't resolve UDP address, skipping peer")
 			continue
 		}
-		log.Printf("resolved %q to %v", peerStr, raddr)
+		//log.Printf("resolved %q to %v", peerStr, raddr)
 
 		if raddr.IP.Equal(localIP) {
-			log.Printf("%v == %v == me, skipping", peerStr, raddr)
+			//log.Print("peer == me, skipping")
 			continue
 		}
 
-		peer := &router.AURPPeer{
-			Transport: &aurp.Transport{
-				LocalDI:     localDI,
-				RemoteDI:    aurp.IPDomainIdentifier(raddr.IP),
-				LocalConnID: nextConnID,
-			},
-			UDPConn:        ln,
-			ConfiguredAddr: peerStr,
-			RemoteAddr:     raddr,
-			ReceiveCh:      make(chan aurp.Packet, 1024),
-			RouteTable:     routes,
-		}
+		peer := router.NewAURPPeer(routes, ln, peerStr, raddr, localDI, nil, nextConnID)
 		aurp.Inc(&nextConnID)
 		peersMu.Lock()
 		peers[udpAddrFromNet(raddr)] = peer
@@ -391,7 +380,7 @@ func main() {
 				return
 			}
 
-			log.Printf("AURP: Got %T from %v (%v)", pkt, raddr, dh.SourceDI)
+			// log.Printf("AURP: Got %T from %v (%v)", pkt, raddr, dh.SourceDI)
 
 			// Existing peer?
 			ra := udpAddrFromNet(raddr)
@@ -399,22 +388,12 @@ func main() {
 			pr := peers[ra]
 			if pr == nil {
 				if !cfg.OpenPeering {
-					log.Printf("AURP: Got packet from %v but it's not in my config and open peering is disabled; dropping the packet", raddr)
+					log.Print("AURP: Got packet but it's not in my config and open peering is disabled; dropping the packet")
 					peersMu.Unlock()
 					continue
 				}
 				// New peer!
-				pr = &router.AURPPeer{
-					Transport: &aurp.Transport{
-						LocalDI:     localDI,
-						RemoteDI:    dh.SourceDI, // platinum rule
-						LocalConnID: nextConnID,
-					},
-					UDPConn:    ln,
-					RemoteAddr: raddr,
-					ReceiveCh:  make(chan aurp.Packet, 1024),
-					RouteTable: routes,
-				}
+				pr = router.NewAURPPeer(routes, ln, "", raddr, localDI, dh.SourceDI, nextConnID)
 				aurp.Inc(&nextConnID)
 				peers[ra] = pr
 				goPeerHandler(pr)

router/peer_aurp.go

@@ -114,6 +114,9 @@ type AURPPeer struct {
 	// Route table (the peer will add/remove/update routes and zones)
 	RouteTable *RouteTable
 
+	// Event tuples yet to be sent to this peer in an RI-Upd.
+	pendingEvents chan aurp.EventTuple
+
 	// The internal states below are only set within the Handle loop, but can
 	// be read concurrently from outside.
 	mu            sync.RWMutex
@@ -126,6 +129,60 @@ type AURPPeer struct {
 	sendRetries   int
 }
 
+func NewAURPPeer(routes *RouteTable, udpConn *net.UDPConn, peerAddr string, raddr *net.UDPAddr, localDI, remoteDI aurp.DomainIdentifier, connID uint16) *AURPPeer {
+	if remoteDI == nil {
+		remoteDI = aurp.IPDomainIdentifier(raddr.IP)
+	}
+	return &AURPPeer{
+		Transport: &aurp.Transport{
+			LocalDI:     localDI,
+			RemoteDI:    remoteDI,
+			LocalConnID: connID,
+		},
+		UDPConn:        udpConn,
+		ConfiguredAddr: peerAddr,
+		RemoteAddr:     raddr,
+		ReceiveCh:      make(chan aurp.Packet, 1024),
+		RouteTable:     routes,
+		pendingEvents:  make(chan aurp.EventTuple, 1024),
+	}
+}
+
+func (p *AURPPeer) addPendingEvent(ec aurp.EventCode, route *Route) {
+	// Don't advertise routes to AURP peers to other AURP peers
+	if route.AURPPeer != nil {
+		return
+	}
+	et := aurp.EventTuple{
+		EventCode:  ec,
+		Extended:   route.Extended,
+		RangeStart: route.NetStart,
+		Distance:   route.Distance,
+		RangeEnd:   route.NetEnd,
+	}
+	switch ec {
+	case aurp.EventCodeND, aurp.EventCodeNRC:
+		et.Distance = 0 // "The distance field does not apply to ND or NRC event tuples and should be set to 0."
+	}
+	p.pendingEvents <- et
+}
+
+func (p *AURPPeer) RouteAdded(route *Route) {
+	p.addPendingEvent(aurp.EventCodeNA, route)
+}
+
+func (p *AURPPeer) RouteDeleted(route *Route) {
+	p.addPendingEvent(aurp.EventCodeND, route)
+}
+
+func (p *AURPPeer) RouteDistanceChanged(route *Route) {
+	p.addPendingEvent(aurp.EventCodeNDC, route)
+}
+
+func (p *AURPPeer) RouteForwarderChanged(route *Route) {
+	p.addPendingEvent(aurp.EventCodeNRC, route)
+}
+
 func (p *AURPPeer) Forward(ddpkt *ddp.ExtPacket) error {
 	outPkt, err := ddp.ExtMarshal(*ddpkt)
 	if err != nil {
@@ -238,7 +295,7 @@ func (p *AURPPeer) send(pkt aurp.Packet) (int, error) {
 	if _, err := pkt.WriteTo(&b); err != nil {
 		return 0, err
 	}
-	log.Printf("AURP Peer: Sending %T (len %d) to %v", pkt, b.Len(), p.RemoteAddr)
+	// log.Printf("AURP Peer: Sending %T (len %d) to %v", pkt, b.Len(), p.RemoteAddr)
 	return p.UDPConn.WriteToUDP(b.Bytes(), p.RemoteAddr)
 }
 
@@ -385,10 +442,10 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 					// In case it's a DNS name, re-resolve it before reconnecting
 					raddr, err := net.ResolveUDPAddr("udp4", p.ConfiguredAddr)
 					if err != nil {
-						log.Printf("couldn't resolve UDP address, skipping: %v", err)
+						log.Print("couldn't resolve UDP address, skipping")
 						break
 					}
-					log.Printf("AURP Peer: resolved %q to %v", p.ConfiguredAddr, raddr)
+					// log.Printf("AURP Peer: resolved %q to %v", p.ConfiguredAddr, raddr)
 					p.RemoteAddr = raddr
 
 					p.bumpLastReconnect()

router/route.go

@@ -55,17 +55,40 @@ func (r *Route) Valid() bool {
 	return len(r.ZoneNames) > 0 && (r.EtherTalkPeer == nil || time.Since(r.LastSeen) <= maxRouteAge)
 }
 
+type RouteTableObserver interface {
+	RouteAdded(*Route)
+	RouteDeleted(*Route)
+	RouteDistanceChanged(*Route)
+	RouteForwarderChanged(*Route)
+}
+
 type RouteTable struct {
-	mu     sync.Mutex
-	routes map[*Route]struct{}
+	routesMu sync.RWMutex
+	routes   map[*Route]struct{}
+
+	observersMu sync.RWMutex
+	observers   map[RouteTableObserver]struct{}
 }
 
 func NewRouteTable() *RouteTable {
 	return &RouteTable{
-		routes: make(map[*Route]struct{}),
+		routes:    make(map[*Route]struct{}),
+		observers: make(map[RouteTableObserver]struct{}),
 	}
 }
 
+func (rt *RouteTable) AddObserver(obs RouteTableObserver) {
+	rt.observersMu.Lock()
+	defer rt.observersMu.Unlock()
+	rt.observers[obs] = struct{}{}
+}
+
+func (rt *RouteTable) RemoveObserver(obs RouteTableObserver) {
+	rt.observersMu.Lock()
+	defer rt.observersMu.Unlock()
+	delete(rt.observers, obs)
+}
+
 func (rt *RouteTable) InsertEtherTalkDirect(port *EtherTalkPort) {
 	r := &Route{
 		Extended:        true,
@@ -77,14 +100,14 @@ func (rt *RouteTable) InsertEtherTalkDirect(port *EtherTalkPort) {
 		EtherTalkDirect: port,
 	}
 
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 	rt.routes[r] = struct{}{}
 }
 
 func (rt *RouteTable) Dump() []Route {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	table := make([]Route, 0, len(rt.routes))
 	for r := range rt.routes {
@@ -94,8 +117,8 @@ func (rt *RouteTable) Dump() []Route {
 }
 
 func (rt *RouteTable) LookupRoute(network ddp.Network) *Route {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	var bestRoute *Route
 	for r := range rt.routes {
@@ -117,8 +140,8 @@ func (rt *RouteTable) LookupRoute(network ddp.Network) *Route {
 }
 
 func (rt *RouteTable) DeleteAURPPeer(peer *AURPPeer) {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer {
@@ -128,8 +151,8 @@ func (rt *RouteTable) DeleteAURPPeer(peer *AURPPeer) {
 }
 
 func (rt *RouteTable) DeleteAURPPeerNetwork(peer *AURPPeer, network ddp.Network) {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer && route.NetStart == network {
@@ -139,8 +162,8 @@ func (rt *RouteTable) DeleteAURPPeerNetwork(peer *AURPPeer, network ddp.Network)
 }
 
 func (rt *RouteTable) UpdateAURPRouteDistance(peer *AURPPeer, network ddp.Network, distance uint8) {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer && route.NetStart == network {
@@ -158,8 +181,8 @@ func (rt *RouteTable) UpsertEtherTalkRoute(peer *EtherTalkPeer, extended bool, n
 		return nil, fmt.Errorf("invalid network range [%d, %d] for nonextended network", netStart, netEnd)
 	}
 
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	// Update?
 	for r := range rt.routes {
@@ -210,16 +233,16 @@ func (rt *RouteTable) InsertAURPRoute(peer *AURPPeer, extended bool, netStart, n
 		AURPPeer: peer,
 	}
 
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 	rt.routes[r] = struct{}{}
 	return nil
 }
 
 // ValidRoutes returns all valid routes.
 func (rt *RouteTable) ValidRoutes() []*Route {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.RLock()
+	defer rt.routesMu.RUnlock()
 	valid := make([]*Route, 0, len(rt.routes))
 	for r := range rt.routes {
 		if r.Valid() {
@@ -231,8 +254,8 @@ func (rt *RouteTable) ValidRoutes() []*Route {
 
 // ValidNonAURPRoutes returns all valid routes that were not learned via AURP.
 func (rt *RouteTable) ValidNonAURPRoutes() []*Route {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.RLock()
+	defer rt.routesMu.RUnlock()
 	valid := make([]*Route, 0, len(rt.routes))
 	for r := range rt.routes {
 		if r.AURPPeer != nil {

router/zones.go

@@ -23,8 +23,8 @@ import (
 )
 
 func (rt *RouteTable) AddZonesToNetwork(n ddp.Network, zs ...string) {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 	for r := range rt.routes {
 		if n < r.NetStart || n > r.NetEnd {
 			continue
@@ -39,8 +39,8 @@ func (rt *RouteTable) AddZonesToNetwork(n ddp.Network, zs ...string) {
 func (rt *RouteTable) ZonesForNetworks(ns []ddp.Network) map[ddp.Network][]string {
 	zs := make(map[ddp.Network][]string)
 
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 	for r := range rt.routes {
 		if !r.Valid() {
 			continue
@@ -55,8 +55,8 @@ func (rt *RouteTable) ZonesForNetworks(ns []ddp.Network) map[ddp.Network][]strin
 }
 
 func (rt *RouteTable) RoutesForZone(zone string) []*Route {
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	var routes []*Route
 	for r := range rt.routes {
@@ -73,8 +73,8 @@ func (rt *RouteTable) RoutesForZone(zone string) []*Route {
 func (rt *RouteTable) AllZoneNames() (zones []string) {
 	defer slices.Sort(zones)
 
-	rt.mu.Lock()
-	defer rt.mu.Unlock()
+	rt.routesMu.Lock()
+	defer rt.routesMu.Unlock()
 
 	zs := make(StringSet)
 	for r := range rt.routes {