Redact list source

README.md

@@ -62,7 +62,3 @@ sudo setcap 'CAP_NET_BIND_SERVICE=ep CAP_NET_RAW=ep' ~/go/bin/jrouter
 * `NET_RAW` is needed for EtherTalk
 
 TODO: instructions for non-Linux machines
-
-## Bug reports? Feature requests? Complaints? Praise? 
-
-You can contact me on the Fediverse at @DrJosh9000@cloudisland.nz, or email me at josh.deprez@gmail.com. 

aurp/routing_info.go

@@ -173,12 +173,9 @@ func (e EventTuples) WriteTo(w io.Writer) (int64, error) {
 }
 
 func parseEventTuples(p []byte) (EventTuples, error) {
-	// Event tuples can be 1, 4, or 6 bytes long. But the only type of length 1
-	// is the Null event type sent to probe whether or not the data receiver is
-	// still listening. If that's present there probably aren't any other
-	// tuples. Hence len(p)/4 (rounded up) is a reasonable estimate of max tuple
-	// count.
-	e := make(EventTuples, 0, (len(p)+3)/4)
+	// Each event tuple is at least 4 bytes, so we need to store at most
+	// len(p)/4 of them.
+	e := make(EventTuples, 0, len(p)/4)
 	for len(p) > 0 {
 		et, nextp, err := parseEventTuple(p)
 		if err != nil {
@@ -201,10 +198,6 @@ type EventTuple struct {
 func (et *EventTuple) WriteTo(w io.Writer) (int64, error) {
 	a := acc(w)
 	a.write8(uint8(et.EventCode))
-	if et.EventCode == EventCodeNull {
-		// null tuple
-		return a.ret()
-	}
 	a.write16(uint16(et.RangeStart))
 	if !et.Extended {
 		// non-extended tuple
@@ -218,18 +211,12 @@ func (et *EventTuple) WriteTo(w io.Writer) (int64, error) {
 }
 
 func parseEventTuple(p []byte) (EventTuple, []byte, error) {
-	if len(p) < 1 {
-		return EventTuple{}, p, fmt.Errorf("insufficient input length %d for any network event tuple", len(p))
+	if len(p) < 4 {
+		return EventTuple{}, p, fmt.Errorf("insufficient input length %d for network event tuple", len(p))
 	}
 
 	var et EventTuple
 	et.EventCode = EventCode(p[0])
-	if et.EventCode == EventCodeNull {
-		return et, p[1:], nil
-	}
-	if len(p) < 4 {
-		return EventTuple{}, p, fmt.Errorf("insufficient input length %d for non-Null network event tuple", len(p))
-	}
 	et.RangeStart = ddp.Network(binary.BigEndian.Uint16(p[1:3]))
 	et.RangeEnd = et.RangeStart
 	et.Distance = p[3]

main.go

@@ -65,13 +65,13 @@ const routingTableTemplate = `
 		<td>{{$route.LastSeenAgo}}</td>
 		<td>
 			{{- with $route.AURPPeer -}}
-				{{.RemoteAddr}}
+				[redacted]
 			{{- end -}}
 			{{- with $route.EtherTalkPeer -}}
 				{{.Port.Device}} {{.PeerAddr.Network}}.{{.PeerAddr.Node}}
 			{{- end -}}
 			{{- with $route.EtherTalkDirect -}}
-				{{.Device}} {{.NetStart}}-{{.NetEnd}}
+				{{.Device}}
 			{{- end -}}
 		</td>
 	</tr>
@@ -87,24 +87,14 @@ const peerTableTemplate = `
 		<th>Remote addr</th>
 		<th>Receiver state</th>
 		<th>Sender state</th>
-		<th>Last heard from</th>
-		<th>Last reconnect</th>
-		<th>Last update</th>
-		<th>Last send</th>
-		<th>Send retries</th>
 	</tr></thead>
 	<tbody>
 {{range $peer := . }}
 	<tr>
-		<td>{{$peer.ConfiguredAddr}}</td>
-		<td>{{$peer.RemoteAddr}}</td>
+		<td>[redacted]</td>
+		<td>[redacted]</td>
 		<td>{{$peer.ReceiverState}}</td>
 		<td>{{$peer.SenderState}}</td>
-		<td>{{$peer.LastHeardFromAgo}}</td>
-		<td>{{$peer.LastReconnectAgo}}</td>
-		<td>{{$peer.LastUpdateAgo}}</td>
-		<td>{{$peer.LastSendAgo}}</td>
-		<td>{{$peer.SendRetries}}</td>		
 	</tr>
 {{end}}
 	</tbody>
@@ -152,9 +142,9 @@ func main() {
 	}
 	localDI := aurp.IPDomainIdentifier(localIP)
 
-	log.Printf("Using %v as local domain identifier", localIP)
+	// log.Printf("Using %v as local domain identifier", localIP)
 
-	log.Printf("EtherTalk configuration: %+v", cfg.EtherTalk)
+	// log.Printf("EtherTalk configuration: %+v", cfg.EtherTalk)
 
 	ln, err := net.ListenUDP("udp4", &net.UDPAddr{Port: int(cfg.ListenPort)})
 	if err != nil {
@@ -256,12 +246,12 @@ func main() {
 
 	// ------------------------- Configured peer setup ------------------------
 	if cfg.PeerListURL != "" {
-		log.Printf("Fetching peer list from %s...", cfg.PeerListURL)
+		log.Print("Fetching peer list...")
 		existing := len(cfg.Peers)
 		func() {
 			resp, err := http.Get(cfg.PeerListURL)
 			if err != nil {
-				log.Fatalf("Couldn't fetch peer list: %v", err)
+				log.Fatalf("Couldn't fetch peer list!")
 			}
 			defer resp.Body.Close()
 
@@ -287,17 +277,28 @@ func main() {
 
 		raddr, err := net.ResolveUDPAddr("udp4", peerStr)
 		if err != nil {
-			log.Printf("couldn't resolve UDP address, skipping: %v", err)
+			log.Print("couldn't resolve UDP address, skipping peer")
 			continue
 		}
-		log.Printf("resolved %q to %v", peerStr, raddr)
+		//log.Printf("resolved %q to %v", peerStr, raddr)
 
 		if raddr.IP.Equal(localIP) {
-			log.Printf("%v == %v == me, skipping", peerStr, raddr)
+			//log.Print("peer == me, skipping")
 			continue
 		}
 
-		peer := router.NewAURPPeer(routes, ln, peerStr, raddr, localDI, nil, nextConnID)
+		peer := &router.AURPPeer{
+			Transport: &aurp.Transport{
+				LocalDI:     localDI,
+				RemoteDI:    aurp.IPDomainIdentifier(raddr.IP),
+				LocalConnID: nextConnID,
+			},
+			UDPConn:        ln,
+			ConfiguredAddr: peerStr,
+			RemoteAddr:     raddr,
+			ReceiveCh:      make(chan aurp.Packet, 1024),
+			RouteTable:     routes,
+		}
 		aurp.Inc(&nextConnID)
 		peersMu.Lock()
 		peers[udpAddrFromNet(raddr)] = peer
@@ -380,7 +381,7 @@ func main() {
 				return
 			}
 
-			log.Printf("AURP: Got %T from %v (%v)", pkt, raddr, dh.SourceDI)
+			// log.Printf("AURP: Got %T from %v (%v)", pkt, raddr, dh.SourceDI)
 
 			// Existing peer?
 			ra := udpAddrFromNet(raddr)
@@ -388,12 +389,22 @@ func main() {
 			pr := peers[ra]
 			if pr == nil {
 				if !cfg.OpenPeering {
-					log.Printf("AURP: Got packet from %v but it's not in my config and open peering is disabled; dropping the packet", raddr)
+					log.Print("AURP: Got packet but it's not in my config and open peering is disabled; dropping the packet")
 					peersMu.Unlock()
 					continue
 				}
 				// New peer!
-				pr = router.NewAURPPeer(routes, ln, "", raddr, localDI, dh.SourceDI, nextConnID)
+				pr = &router.AURPPeer{
+					Transport: &aurp.Transport{
+						LocalDI:     localDI,
+						RemoteDI:    dh.SourceDI, // platinum rule
+						LocalConnID: nextConnID,
+					},
+					UDPConn:    ln,
+					RemoteAddr: raddr,
+					ReceiveCh:  make(chan aurp.Packet, 1024),
+					RouteTable: routes,
+				}
 				aurp.Inc(&nextConnID)
 				peers[ra] = pr
 				goPeerHandler(pr)

router/aarp.go

@@ -37,8 +37,6 @@ const (
 	maxAMTEntryAge        = 30 * time.Second
 	aarpRequestRetransmit = 1 * time.Second
 	aarpRequestTimeout    = 10 * time.Second
-
-	aarpBodyLength = 28 // bytes
 )
 
 const aarpStatusTemplate = `
@@ -183,17 +181,8 @@ func (a *AARPMachine) Run(ctx context.Context) error {
 				a.incomingCh = nil
 			}
 
-			// sfiera/multitalk will return an "excess data" error if the
-			// payload is too big. Most traffic I've seen locally does not have
-			// this problem, but I've seen one report with some junk trailing
-			// data on AARP packets.
-			payload := ethFrame.Payload
-			if len(payload) > aarpBodyLength {
-				payload = payload[:aarpBodyLength]
-			}
-
 			var aapkt aarp.Packet
-			if err := aarp.Unmarshal(payload, &aapkt); err != nil {
+			if err := aarp.Unmarshal(ethFrame.Payload, &aapkt); err != nil {
 				log.Printf("Couldn't unmarshal AARP packet: %v", err)
 				continue
 			}
@@ -389,7 +378,10 @@ func (e AMTEntry) Valid() bool {
 // LastUpdatedAgo is a friendly string reporting how long ago the entry was
 // updated/resolved.
 func (e AMTEntry) LastUpdatedAgo() string {
-	return ago(e.LastUpdated)
+	if e.LastUpdated.IsZero() {
+		return "never"
+	}
+	return fmt.Sprintf("%v ago", time.Since(e.LastUpdated).Truncate(time.Millisecond))
 }
 
 // addressMappingTable implements a concurrent-safe Address Mapping Table for

router/misc.go

@@ -16,11 +16,6 @@
 
 package router
 
-import (
-	"fmt"
-	"time"
-)
-
 // StringSet is a set of strings.
 // Yep, yet another string set implementation. Took me 2 minutes to write *shrug*
 type StringSet map[string]struct{}
@@ -55,11 +50,3 @@ func SetFromSlice(ss []string) StringSet {
 	set.Insert(ss...)
 	return set
 }
-
-// ago is a helper for formatting times.
-func ago(t time.Time) string {
-	if t.IsZero() {
-		return "never"
-	}
-	return fmt.Sprintf("%v ago", time.Since(t).Truncate(time.Millisecond))
-}

router/peer_aurp.go

@@ -114,75 +114,9 @@ type AURPPeer struct {
 	// Route table (the peer will add/remove/update routes and zones)
 	RouteTable *RouteTable
 
-	// Event tuples yet to be sent to this peer in an RI-Upd.
-	pendingEventsMu sync.Mutex
-	pendingEvents   aurp.EventTuples
-
-	// The internal states below are only set within the Handle loop, but can
-	// be read concurrently from outside.
-	mu            sync.RWMutex
-	rstate        ReceiverState
-	sstate        SenderState
-	lastReconnect time.Time
-	lastHeardFrom time.Time
-	lastSend      time.Time // TODO: clarify use of lastSend / sendRetries
-	lastUpdate    time.Time
-	sendRetries   int
-}
-
-func NewAURPPeer(routes *RouteTable, udpConn *net.UDPConn, peerAddr string, raddr *net.UDPAddr, localDI, remoteDI aurp.DomainIdentifier, connID uint16) *AURPPeer {
-	if remoteDI == nil {
-		remoteDI = aurp.IPDomainIdentifier(raddr.IP)
-	}
-	return &AURPPeer{
-		Transport: &aurp.Transport{
-			LocalDI:     localDI,
-			RemoteDI:    remoteDI,
-			LocalConnID: connID,
-		},
-		UDPConn:        udpConn,
-		ConfiguredAddr: peerAddr,
-		RemoteAddr:     raddr,
-		ReceiveCh:      make(chan aurp.Packet, 1024),
-		RouteTable:     routes,
-	}
-}
-
-func (p *AURPPeer) addPendingEvent(ec aurp.EventCode, route *Route) {
-	// Don't advertise routes to AURP peers to other AURP peers
-	if route.AURPPeer != nil {
-		return
-	}
-	et := aurp.EventTuple{
-		EventCode:  ec,
-		Extended:   route.Extended,
-		RangeStart: route.NetStart,
-		Distance:   route.Distance,
-		RangeEnd:   route.NetEnd,
-	}
-	switch ec {
-	case aurp.EventCodeND, aurp.EventCodeNRC:
-		et.Distance = 0 // "The distance field does not apply to ND or NRC event tuples and should be set to 0."
-	}
-	p.pendingEventsMu.Lock()
-	defer p.pendingEventsMu.Unlock()
-	p.pendingEvents = append(p.pendingEvents, et)
-}
-
-func (p *AURPPeer) RouteAdded(route *Route) {
-	p.addPendingEvent(aurp.EventCodeNA, route)
-}
-
-func (p *AURPPeer) RouteDeleted(route *Route) {
-	p.addPendingEvent(aurp.EventCodeND, route)
-}
-
-func (p *AURPPeer) RouteDistanceChanged(route *Route) {
-	p.addPendingEvent(aurp.EventCodeNDC, route)
-}
-
-func (p *AURPPeer) RouteForwarderChanged(route *Route) {
-	p.addPendingEvent(aurp.EventCodeNRC, route)
+	mu     sync.RWMutex
+	rstate ReceiverState
+	sstate SenderState
 }
 
 func (p *AURPPeer) Forward(ddpkt *ddp.ExtPacket) error {
@@ -190,7 +124,7 @@ func (p *AURPPeer) Forward(ddpkt *ddp.ExtPacket) error {
 	if err != nil {
 		return err
 	}
-	_, err = p.send(p.Transport.NewAppleTalkPacket(outPkt))
+	_, err = p.Send(p.Transport.NewAppleTalkPacket(outPkt))
 	return err
 }
 
@@ -206,36 +140,6 @@ func (p *AURPPeer) SenderState() SenderState {
 	return p.sstate
 }
 
-func (p *AURPPeer) LastReconnectAgo() string {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-	return ago(p.lastReconnect)
-}
-
-func (p *AURPPeer) LastHeardFromAgo() string {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-	return ago(p.lastHeardFrom)
-}
-
-func (p *AURPPeer) LastSendAgo() string {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-	return ago(p.lastSend)
-}
-
-func (p *AURPPeer) LastUpdateAgo() string {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-	return ago(p.lastUpdate)
-}
-
-func (p *AURPPeer) SendRetries() int {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-	return p.sendRetries
-}
-
 func (p *AURPPeer) setRState(rstate ReceiverState) {
 	p.mu.Lock()
 	defer p.mu.Unlock()
@@ -248,42 +152,6 @@ func (p *AURPPeer) setSState(sstate SenderState) {
 	p.sstate = sstate
 }
 
-func (p *AURPPeer) incSendRetries() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.sendRetries++
-}
-
-func (p *AURPPeer) resetSendRetries() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.sendRetries = 0
-}
-
-func (p *AURPPeer) bumpLastHeardFrom() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.lastHeardFrom = time.Now()
-}
-
-func (p *AURPPeer) bumpLastReconnect() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.lastReconnect = time.Now()
-}
-
-func (p *AURPPeer) bumpLastSend() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.lastSend = time.Now()
-}
-
-func (p *AURPPeer) bumpLastUpdate() {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-	p.lastUpdate = time.Now()
-}
-
 func (p *AURPPeer) disconnect() {
 	p.mu.Lock()
 	defer p.mu.Unlock()
@@ -291,39 +159,34 @@ func (p *AURPPeer) disconnect() {
 	p.sstate = SenderUnconnected
 }
 
-// send encodes and sends pkt to the remote host.
-func (p *AURPPeer) send(pkt aurp.Packet) (int, error) {
+// Send encodes and sends pkt to the remote host.
+func (p *AURPPeer) Send(pkt aurp.Packet) (int, error) {
 	var b bytes.Buffer
 	if _, err := pkt.WriteTo(&b); err != nil {
 		return 0, err
 	}
-	log.Printf("AURP Peer: Sending %T (len %d) to %v", pkt, b.Len(), p.RemoteAddr)
+	// log.Printf("AURP Peer: Sending %T (len %d) to %v", pkt, b.Len(), p.RemoteAddr)
 	return p.UDPConn.WriteToUDP(b.Bytes(), p.RemoteAddr)
 }
 
 func (p *AURPPeer) Handle(ctx context.Context) error {
-	// Stop listening to events if the goroutine exits
-	defer p.RouteTable.RemoveObserver(p)
-
 	rticker := time.NewTicker(1 * time.Second)
 	defer rticker.Stop()
 	sticker := time.NewTicker(1 * time.Second)
 	defer sticker.Stop()
 
-	p.mu.Lock()
-	p.lastReconnect = time.Now()
-	p.lastHeardFrom = time.Now()
-	p.lastSend = time.Now() // TODO: clarify use of lastSend / sendRetries
-	p.lastUpdate = time.Now()
-	p.sendRetries = 0
-	p.mu.Unlock()
+	lastReconnect := time.Now()
+	lastHeardFrom := time.Now()
+	lastSend := time.Now() // TODO: clarify use of lastSend / sendRetries
+	lastUpdate := time.Now()
+	sendRetries := 0
 
 	var lastRISent aurp.Packet
 
 	p.disconnect()
 
 	// Write an Open-Req packet
-	if _, err := p.send(p.Transport.NewOpenReqPacket(nil)); err != nil {
+	if _, err := p.Send(p.Transport.NewOpenReqPacket(nil)); err != nil {
 		log.Printf("AURP Peer: Couldn't send Open-Req packet: %v", err)
 		return err
 	}
@@ -339,7 +202,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 			}
 			// Send a best-effort Router Down before returning
 			lastRISent = p.Transport.NewRDPacket(aurp.ErrCodeNormalClose)
-			if _, err := p.send(lastRISent); err != nil {
+			if _, err := p.Send(lastRISent); err != nil {
 				log.Printf("Couldn't send RD packet: %v", err)
 			}
 			return ctx.Err()
@@ -347,60 +210,60 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 		case <-rticker.C:
 			switch p.rstate {
 			case ReceiverWaitForOpenRsp:
-				if time.Since(p.lastSend) <= sendRetryTimer {
+				if time.Since(lastSend) <= sendRetryTimer {
 					break
 				}
-				if p.sendRetries >= sendRetryLimit {
+				if sendRetries >= sendRetryLimit {
 					log.Printf("AURP Peer: Send retry limit reached while waiting for Open-Rsp, closing connection")
 					p.setRState(ReceiverUnconnected)
 					break
 				}
 
 				// Send another Open-Req
-				p.incSendRetries()
-				p.bumpLastSend()
-				if _, err := p.send(p.Transport.NewOpenReqPacket(nil)); err != nil {
+				sendRetries++
+				lastSend = time.Now()
+				if _, err := p.Send(p.Transport.NewOpenReqPacket(nil)); err != nil {
 					log.Printf("AURP Peer: Couldn't send Open-Req packet: %v", err)
 					return err
 				}
 
 			case ReceiverConnected:
 				// Check LHFT, send tickle?
-				if time.Since(p.lastHeardFrom) <= lastHeardFromTimer {
+				if time.Since(lastHeardFrom) <= lastHeardFromTimer {
 					break
 				}
-				if _, err := p.send(p.Transport.NewTicklePacket()); err != nil {
+				if _, err := p.Send(p.Transport.NewTicklePacket()); err != nil {
 					log.Printf("AURP Peer: Couldn't send Tickle: %v", err)
 					return err
 				}
 				p.setRState(ReceiverWaitForTickleAck)
-				p.resetSendRetries()
-				p.bumpLastSend()
+				sendRetries = 0
+				lastSend = time.Now()
 
 			case ReceiverWaitForTickleAck:
-				if time.Since(p.lastSend) <= sendRetryTimer {
+				if time.Since(lastSend) <= sendRetryTimer {
 					break
 				}
-				if p.sendRetries >= tickleRetryLimit {
+				if sendRetries >= tickleRetryLimit {
 					log.Printf("AURP Peer: Send retry limit reached while waiting for Tickle-Ack, closing connection")
 					p.setRState(ReceiverUnconnected)
 					p.RouteTable.DeleteAURPPeer(p)
 					break
 				}
 
-				p.incSendRetries()
-				p.bumpLastSend()
-				if _, err := p.send(p.Transport.NewTicklePacket()); err != nil {
+				sendRetries++
+				lastSend = time.Now()
+				if _, err := p.Send(p.Transport.NewTicklePacket()); err != nil {
 					log.Printf("AURP Peer: Couldn't send Tickle: %v", err)
 					return err
 				}
 				// still in Wait For Tickle-Ack
 
 			case ReceiverWaitForRIRsp:
-				if time.Since(p.lastSend) <= sendRetryTimer {
+				if time.Since(lastSend) <= sendRetryTimer {
 					break
 				}
-				if p.sendRetries >= sendRetryLimit {
+				if sendRetries >= sendRetryLimit {
 					log.Printf("AURP Peer: Send retry limit reached while waiting for RI-Rsp, closing connection")
 					p.setRState(ReceiverUnconnected)
 					p.RouteTable.DeleteAURPPeer(p)
@@ -409,9 +272,8 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 
 				// RI-Req is stateless, so we don't need to cache the one we
 				// sent earlier just to send it again
-				p.incSendRetries()
-				p.bumpLastSend()
-				if _, err := p.send(p.Transport.NewRIReqPacket()); err != nil {
+				sendRetries++
+				if _, err := p.Send(p.Transport.NewRIReqPacket()); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Req packet: %v", err)
 					return err
 				}
@@ -420,18 +282,18 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 			case ReceiverUnconnected:
 				// Data receiver is unconnected. If data sender is connected,
 				// send a null RI-Upd to check if the sender is also unconnected
-				if p.sstate == SenderConnected && time.Since(p.lastSend) > sendRetryTimer {
-					if p.sendRetries >= sendRetryLimit {
-						log.Printf("AURP Peer: Send retry limit reached while probing sender connect, closing connection")
+				if p.sstate == SenderConnected && time.Since(lastSend) > sendRetryTimer {
+					if sendRetries >= sendRetryLimit {
+						log.Print("AURP Peer: Send retry limit reached while probing sender connect, closing connection")
 					}
-					p.incSendRetries()
-					p.bumpLastSend()
+					sendRetries++
+					lastSend = time.Now()
 					aurp.Inc(&p.Transport.LocalSeq)
 					events := aurp.EventTuples{{
 						EventCode: aurp.EventCodeNull,
 					}}
 					lastRISent = p.Transport.NewRIUpdPacket(events)
-					if _, err := p.send(lastRISent); err != nil {
+					if _, err := p.Send(lastRISent); err != nil {
 						log.Printf("AURP Peer: Couldn't send RI-Upd packet: %v", err)
 						return err
 					}
@@ -440,23 +302,23 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 
 				if p.ConfiguredAddr != "" {
 					// Periodically try to reconnect, if this peer is in the config file
-					if time.Since(p.lastReconnect) <= reconnectTimer {
+					if time.Since(lastReconnect) <= reconnectTimer {
 						break
 					}
 
 					// In case it's a DNS name, re-resolve it before reconnecting
 					raddr, err := net.ResolveUDPAddr("udp4", p.ConfiguredAddr)
 					if err != nil {
-						log.Printf("couldn't resolve UDP address, skipping: %v", err)
+						log.Print("couldn't resolve UDP address, skipping")
 						break
 					}
-					log.Printf("AURP Peer: resolved %q to %v", p.ConfiguredAddr, raddr)
+					// log.Printf("AURP Peer: resolved %q to %v", p.ConfiguredAddr, raddr)
 					p.RemoteAddr = raddr
 
-					p.bumpLastReconnect()
-					p.resetSendRetries()
-					p.bumpLastSend()
-					if _, err := p.send(p.Transport.NewOpenReqPacket(nil)); err != nil {
+					lastReconnect = time.Now()
+					sendRetries = 0
+					lastSend = time.Now()
+					if _, err := p.Send(p.Transport.NewOpenReqPacket(nil)); err != nil {
 						log.Printf("AURP Peer: Couldn't send Open-Req packet: %v", err)
 						return err
 					}
@@ -470,64 +332,40 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				// Do nothing
 
 			case SenderConnected:
-				if time.Since(p.lastUpdate) <= updateTimer {
+				if time.Since(lastUpdate) <= updateTimer {
 					break
 				}
-
-				// Are there routing updates to send?
-				p.pendingEventsMu.Lock()
-				if len(p.pendingEvents) == 0 {
-					p.pendingEventsMu.Unlock()
-					break
-				}
-				// Yes - swap the slices, release the mutex, then send them
-				pending := p.pendingEvents
-				p.pendingEvents = make(aurp.EventTuples, 0, cap(pending))
-				p.pendingEventsMu.Unlock()
-
-				// TODO: eliminate events that cancel out (e.g. NA then ND)
-				// TODO: split pending events to fit within a packet
-
-				p.bumpLastUpdate()
-				aurp.Inc(&p.Transport.LocalSeq)
-				lastRISent = p.Transport.NewRIUpdPacket(pending)
-				if _, err := p.send(lastRISent); err != nil {
-					log.Printf("AURP Peer: Couldn't send RI-Upd packet: %v", err)
-					return err
-				}
-				p.setSState(SenderWaitForRIUpdAck)
+				// TODO: is there a routing update to send?
 
 			case SenderWaitForRIRspAck, SenderWaitForRIUpdAck:
-				if time.Since(p.lastSend) <= sendRetryTimer {
+				if time.Since(lastSend) <= sendRetryTimer {
 					break
 				}
 				if lastRISent == nil {
 					log.Print("AURP Peer: sender retry: lastRISent = nil?")
 					continue
 				}
-				if p.sendRetries >= sendRetryLimit {
+				if sendRetries >= sendRetryLimit {
 					log.Printf("AURP Peer: Send retry limit reached, closing connection")
 					p.setSState(SenderUnconnected)
-					p.RouteTable.RemoveObserver(p)
 					continue
 				}
-				p.incSendRetries()
-				p.bumpLastSend()
-				if _, err := p.send(lastRISent); err != nil {
+				sendRetries++
+				lastSend = time.Now()
+				if _, err := p.Send(lastRISent); err != nil {
 					log.Printf("AURP Peer: Couldn't re-send %T: %v", lastRISent, err)
 					return err
 				}
 
 			case SenderWaitForRDAck:
-				if time.Since(p.lastSend) <= sendRetryTimer {
+				if time.Since(lastSend) <= sendRetryTimer {
 					break
 				}
 				p.setSState(SenderUnconnected)
-				p.RouteTable.RemoveObserver(p)
 			}
 
 		case pkt := <-p.ReceiveCh:
-			p.bumpLastHeardFrom()
+			lastHeardFrom = time.Now()
 
 			switch pkt := pkt.(type) {
 			case *aurp.OpenReqPacket:
@@ -554,21 +392,19 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 					orsp = p.Transport.NewOpenRspPacket(0, 1, nil)
 				}
 
-				if _, err := p.send(orsp); err != nil {
+				if _, err := p.Send(orsp); err != nil {
 					log.Printf("AURP Peer: Couldn't send Open-Rsp: %v", err)
 					return err
 				}
 				if orsp.RateOrErrCode >= 0 {
-					// Data sender is successfully in connected state
 					p.setSState(SenderConnected)
-					p.RouteTable.AddObserver(p)
 				}
 
 				// If receiver is unconnected, commence connecting
 				if p.rstate == ReceiverUnconnected {
-					p.resetSendRetries()
-					p.bumpLastSend()
-					if _, err := p.send(p.Transport.NewOpenReqPacket(nil)); err != nil {
+					lastSend = time.Now()
+					sendRetries = 0
+					if _, err := p.Send(p.Transport.NewOpenReqPacket(nil)); err != nil {
 						log.Printf("AURP Peer: Couldn't send Open-Req packet: %v", err)
 						return err
 					}
@@ -589,8 +425,8 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				p.setRState(ReceiverConnected)
 
 				// Send an RI-Req
-				p.resetSendRetries()
-				if _, err := p.send(p.Transport.NewRIReqPacket()); err != nil {
+				sendRetries = 0
+				if _, err := p.Send(p.Transport.NewRIReqPacket()); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Req packet: %v", err)
 					return err
 				}
@@ -613,7 +449,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				p.Transport.LocalSeq = 1
 				// TODO: Split tuples across multiple packets as required
 				lastRISent = p.Transport.NewRIRspPacket(aurp.RoutingFlagLast, nets)
-				if _, err := p.send(lastRISent); err != nil {
+				if _, err := p.Send(lastRISent); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Rsp packet: %v", err)
 					return err
 				}
@@ -638,7 +474,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 
 				// TODO: track which networks we don't have zone info for, and
 				// only set SZI for those ?
-				if _, err := p.send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, aurp.RoutingFlagSendZoneInfo)); err != nil {
+				if _, err := p.Send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, aurp.RoutingFlagSendZoneInfo)); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Ack packet: %v", err)
 					return err
 				}
@@ -664,8 +500,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				}
 
 				p.setSState(SenderConnected)
-				p.resetSendRetries()
-				p.RouteTable.AddObserver(p)
+				sendRetries = 0
 
 				// If SZI flag is set, send ZI-Rsp (transaction)
 				if pkt.Flags&aurp.RoutingFlagSendZoneInfo != 0 {
@@ -690,7 +525,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 					}
 					zones := p.RouteTable.ZonesForNetworks(nets)
 					// TODO: split ZI-Rsp packets similarly to ZIP Replies
-					if _, err := p.send(p.Transport.NewZIRspPacket(zones)); err != nil {
+					if _, err := p.Send(p.Transport.NewZIRspPacket(zones)); err != nil {
 						log.Printf("AURP Peer: Couldn't send ZI-Rsp packet: %v", err)
 					}
 				}
@@ -701,9 +536,9 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 					// Receiver is unconnected, but their receiver sent us an
 					// RI-Ack for something
 					// Try to reconnect?
-					p.resetSendRetries()
-					p.bumpLastSend()
-					if _, err := p.send(p.Transport.NewOpenReqPacket(nil)); err != nil {
+					lastSend = time.Now()
+					sendRetries = 0
+					if _, err := p.Send(p.Transport.NewOpenReqPacket(nil)); err != nil {
 						log.Printf("AURP Peer: Couldn't send Open-Req packet: %v", err)
 						return err
 					}
@@ -711,6 +546,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				}
 
 			case *aurp.RIUpdPacket:
+
 				var ackFlag aurp.RoutingFlag
 
 				for _, et := range pkt.Events {
@@ -750,7 +586,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 					}
 				}
 
-				if _, err := p.send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, ackFlag)); err != nil {
+				if _, err := p.Send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, ackFlag)); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Ack: %v", err)
 					return err
 				}
@@ -764,7 +600,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				p.RouteTable.DeleteAURPPeer(p)
 
 				// Respond with RI-Ack
-				if _, err := p.send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, 0)); err != nil {
+				if _, err := p.Send(p.Transport.NewRIAckPacket(pkt.ConnectionID, pkt.Sequence, 0)); err != nil {
 					log.Printf("AURP Peer: Couldn't send RI-Ack: %v", err)
 					return err
 				}
@@ -774,7 +610,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 			case *aurp.ZIReqPacket:
 				// TODO: split ZI-Rsp packets similarly to ZIP Replies
 				zones := p.RouteTable.ZonesForNetworks(pkt.Networks)
-				if _, err := p.send(p.Transport.NewZIRspPacket(zones)); err != nil {
+				if _, err := p.Send(p.Transport.NewZIRspPacket(zones)); err != nil {
 					log.Printf("AURP Peer: Couldn't send ZI-Rsp packet: %v", err)
 					return err
 				}
@@ -786,7 +622,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				}
 
 			case *aurp.GDZLReqPacket:
-				if _, err := p.send(p.Transport.NewGDZLRspPacket(-1, nil)); err != nil {
+				if _, err := p.Send(p.Transport.NewGDZLRspPacket(-1, nil)); err != nil {
 					log.Printf("AURP Peer: Couldn't send GDZL-Rsp packet: %v", err)
 					return err
 				}
@@ -795,7 +631,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 				log.Printf("AURP Peer: Received a GDZL-Rsp, but I wouldn't have sent a GDZL-Req - that's weird")
 
 			case *aurp.GZNReqPacket:
-				if _, err := p.send(p.Transport.NewGZNRspPacket(pkt.ZoneName, false, nil)); err != nil {
+				if _, err := p.Send(p.Transport.NewGZNRspPacket(pkt.ZoneName, false, nil)); err != nil {
 					log.Printf("AURP Peer: Couldn't send GZN-Rsp packet: %v", err)
 					return err
 				}
@@ -805,7 +641,7 @@ func (p *AURPPeer) Handle(ctx context.Context) error {
 
 			case *aurp.TicklePacket:
 				// Immediately respond with Tickle-Ack
-				if _, err := p.send(p.Transport.NewTickleAckPacket()); err != nil {
+				if _, err := p.Send(p.Transport.NewTickleAckPacket()); err != nil {
 					log.Printf("AURP Peer: Couldn't send Tickle-Ack: %v", err)
 					return err
 				}

router/port.go

@@ -18,7 +18,6 @@ package router
 
 import (
 	"context"
-	"encoding/binary"
 	"errors"
 	"io"
 	"log"
@@ -80,18 +79,8 @@ func (port *EtherTalkPort) Serve(ctx context.Context) {
 
 		case ethertalk.AppleTalkProto:
 			// log.Print("Got an AppleTalk frame")
-
-			// Workaround for strict length checking in sfiera/multitalk
-			payload := ethFrame.Payload
-			if len(payload) < 2 {
-				log.Printf("Couldn't unmarshal DDP packet: too small (length = %d)", len(payload))
-			}
-			if size := binary.BigEndian.Uint16(payload[:2]) & 0x3ff; len(payload) > int(size) {
-				payload = payload[:size]
-			}
-
 			ddpkt := new(ddp.ExtPacket)
-			if err := ddp.ExtUnmarshal(payload, ddpkt); err != nil {
+			if err := ddp.ExtUnmarshal(ethFrame.Payload, ddpkt); err != nil {
 				log.Printf("Couldn't unmarshal DDP packet: %v", err)
 				continue
 			}

router/route.go

@@ -45,7 +45,10 @@ type Route struct {
 }
 
 func (r Route) LastSeenAgo() string {
-	return ago(r.LastSeen)
+	if r.LastSeen.IsZero() {
+		return "never"
+	}
+	return fmt.Sprintf("%v ago", time.Since(r.LastSeen).Truncate(time.Millisecond))
 }
 
 // Valid reports whether the route is valid.
@@ -55,40 +58,17 @@ func (r *Route) Valid() bool {
 	return len(r.ZoneNames) > 0 && (r.EtherTalkPeer == nil || time.Since(r.LastSeen) <= maxRouteAge)
 }
 
-type RouteTableObserver interface {
-	RouteAdded(*Route)
-	RouteDeleted(*Route)
-	RouteDistanceChanged(*Route)
-	RouteForwarderChanged(*Route)
-}
-
 type RouteTable struct {
-	routesMu sync.RWMutex
-	routes   map[*Route]struct{}
-
-	observersMu sync.RWMutex
-	observers   map[RouteTableObserver]struct{}
+	mu     sync.Mutex
+	routes map[*Route]struct{}
 }
 
 func NewRouteTable() *RouteTable {
 	return &RouteTable{
-		routes:    make(map[*Route]struct{}),
-		observers: make(map[RouteTableObserver]struct{}),
+		routes: make(map[*Route]struct{}),
 	}
 }
 
-func (rt *RouteTable) AddObserver(obs RouteTableObserver) {
-	rt.observersMu.Lock()
-	defer rt.observersMu.Unlock()
-	rt.observers[obs] = struct{}{}
-}
-
-func (rt *RouteTable) RemoveObserver(obs RouteTableObserver) {
-	rt.observersMu.Lock()
-	defer rt.observersMu.Unlock()
-	delete(rt.observers, obs)
-}
-
 func (rt *RouteTable) InsertEtherTalkDirect(port *EtherTalkPort) {
 	r := &Route{
 		Extended:        true,
@@ -100,14 +80,14 @@ func (rt *RouteTable) InsertEtherTalkDirect(port *EtherTalkPort) {
 		EtherTalkDirect: port,
 	}
 
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	rt.routes[r] = struct{}{}
 }
 
 func (rt *RouteTable) Dump() []Route {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	table := make([]Route, 0, len(rt.routes))
 	for r := range rt.routes {
@@ -117,8 +97,8 @@ func (rt *RouteTable) Dump() []Route {
 }
 
 func (rt *RouteTable) LookupRoute(network ddp.Network) *Route {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	var bestRoute *Route
 	for r := range rt.routes {
@@ -140,8 +120,8 @@ func (rt *RouteTable) LookupRoute(network ddp.Network) *Route {
 }
 
 func (rt *RouteTable) DeleteAURPPeer(peer *AURPPeer) {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer {
@@ -151,8 +131,8 @@ func (rt *RouteTable) DeleteAURPPeer(peer *AURPPeer) {
 }
 
 func (rt *RouteTable) DeleteAURPPeerNetwork(peer *AURPPeer, network ddp.Network) {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer && route.NetStart == network {
@@ -162,8 +142,8 @@ func (rt *RouteTable) DeleteAURPPeerNetwork(peer *AURPPeer, network ddp.Network)
 }
 
 func (rt *RouteTable) UpdateAURPRouteDistance(peer *AURPPeer, network ddp.Network, distance uint8) {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	for route := range rt.routes {
 		if route.AURPPeer == peer && route.NetStart == network {
@@ -181,8 +161,8 @@ func (rt *RouteTable) UpsertEtherTalkRoute(peer *EtherTalkPeer, extended bool, n
 		return nil, fmt.Errorf("invalid network range [%d, %d] for nonextended network", netStart, netEnd)
 	}
 
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	// Update?
 	for r := range rt.routes {
@@ -233,16 +213,16 @@ func (rt *RouteTable) InsertAURPRoute(peer *AURPPeer, extended bool, netStart, n
 		AURPPeer: peer,
 	}
 
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	rt.routes[r] = struct{}{}
 	return nil
 }
 
 // ValidRoutes returns all valid routes.
 func (rt *RouteTable) ValidRoutes() []*Route {
-	rt.routesMu.RLock()
-	defer rt.routesMu.RUnlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	valid := make([]*Route, 0, len(rt.routes))
 	for r := range rt.routes {
 		if r.Valid() {
@@ -254,8 +234,8 @@ func (rt *RouteTable) ValidRoutes() []*Route {
 
 // ValidNonAURPRoutes returns all valid routes that were not learned via AURP.
 func (rt *RouteTable) ValidNonAURPRoutes() []*Route {
-	rt.routesMu.RLock()
-	defer rt.routesMu.RUnlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	valid := make([]*Route, 0, len(rt.routes))
 	for r := range rt.routes {
 		if r.AURPPeer != nil {

router/zones.go

@@ -23,8 +23,8 @@ import (
 )
 
 func (rt *RouteTable) AddZonesToNetwork(n ddp.Network, zs ...string) {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	for r := range rt.routes {
 		if n < r.NetStart || n > r.NetEnd {
 			continue
@@ -39,8 +39,8 @@ func (rt *RouteTable) AddZonesToNetwork(n ddp.Network, zs ...string) {
 func (rt *RouteTable) ZonesForNetworks(ns []ddp.Network) map[ddp.Network][]string {
 	zs := make(map[ddp.Network][]string)
 
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 	for r := range rt.routes {
 		if !r.Valid() {
 			continue
@@ -55,8 +55,8 @@ func (rt *RouteTable) ZonesForNetworks(ns []ddp.Network) map[ddp.Network][]strin
 }
 
 func (rt *RouteTable) RoutesForZone(zone string) []*Route {
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	var routes []*Route
 	for r := range rt.routes {
@@ -73,8 +73,8 @@ func (rt *RouteTable) RoutesForZone(zone string) []*Route {
 func (rt *RouteTable) AllZoneNames() (zones []string) {
 	defer slices.Sort(zones)
 
-	rt.routesMu.Lock()
-	defer rt.routesMu.Unlock()
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
 
 	zs := make(StringSet)
 	for r := range rt.routes {